Should I transfer now or wait?

Doesn’t hurt to try. But if you get a 3.8 from SUNY Buffalo and do research, you’ll have a shot at some of the very top grad schools.

" From what I have seen, proffessors who work in places like MIT, UCB, UCLA, Vanderbilt and other similar universities fo not go to regulars state schools for their undegrad."

I’m glad you rescinded that statement…=). UIllinois is head and shoulders above Vandy (and arguably UCLA) for engineering.

You’re young though. Lots of years ahead of you. I got my engineering Ph.D. at Stanford. I had tons of classmates at Stanford that excelled at average state schools (including your own SUNY Buffalo, UT Arlington, Vtech, etc etc) for undergrad. And guess what? A lot of my grad school classmates with Ph.D.s that wanted a faculty teaching position had to settle for worse schools than what you would deem regular state schools (including absolute podunk non-PhD schools like Cal State Chico). Getting a faculty position at a top school is incredibly incredibly tough and requires a bit of luck too.

A top graduate school does not guarantee that job nor does a slightly “lesser school” preclude you from such a faculty position either.