Will this look bad to colleges? - 4 vs 6 years of foreign language

No

For most, but not all, middle schools, 7th + 8th is the equivalent to one year of HS, so you are really talking 4 years vs. 5. But again, it will make no difference.